[PATCH] D74327: [mlir][VectorOps] Adds canonicalization rewrite patterns for vector ShapeCastOp.
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 13:48:41 PST 2020
nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.
Nice pattern composition Andy!
================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:686
+//
+// EX:
+//
----------------
nit: we have historically spelled it out as `Example:`
================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:697
+//
+//
+// %0 = source : vector<5x4x2xf32>
----------------
nit: extra line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74327/new/
https://reviews.llvm.org/D74327
More information about the llvm-commits
mailing list