[PATCH] D74312: [DebugInfo]: Added preliminary support for DWARFv5 in llvm-dwp utility.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:94
+    Out.EmitIntValue(Size - 4, 4);
+    Out.EmitIntValue(5, 2); // Version.
+    Out.EmitIntValue(0, 2); // Padding.
----------------
nit: this should be
```
// Emit the version.
Out.EmitIntValue(5, 2); 
// Emit two bytes padding.
Out.EmitIntValue(0, 2);
```


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:589
 
+    /*Here we're extracting Dwarf Version from Info Section to pass it
+     * for reconstruction of debug_str_offset section based on Dwarf Version.
----------------
//


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:590
+    /*Here we're extracting Dwarf Version from Info Section to pass it
+     * for reconstruction of debug_str_offset section based on Dwarf Version.
+     */
----------------
on *the* DWARF version


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74312/new/

https://reviews.llvm.org/D74312