[PATCH] D73329: [libFuzzer] communicate through pipe to subprocess for MinimizeCrashInput

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:321
+  FILE *Pipe = OpenProcessPipe(Cmd.toString().c_str(), "r");
+  if (!Pipe)
+    return 1;
----------------
exit code is used to check only success
please make it bool
true - success
false - error


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:502
+  std::string CFPath = CFPathOrNull ? CFPathOrNull : TempPath("Merge", ".txt");
   Vector<std::string> NewFiles;
   Set<uint32_t> NewFeatures, NewCov;
----------------
This verbosity in temp names is nice but irrelevant to the goal of the patch.
Could you extract this into a separate NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73329/new/

https://reviews.llvm.org/D73329