[llvm] bc8e442 - [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS

[Martin Storsjö via llvm-commits]

Author: Martin Storsjö
Date: 2020-02-10T22:50:36+02:00
New Revision: bc8e44218810c0db6328b9809c959ceb7d43e3f5

URL: https://github.com/llvm/llvm-project/commit/bc8e44218810c0db6328b9809c959ceb7d43e3f5
DIFF: https://github.com/llvm/llvm-project/commit/bc8e44218810c0db6328b9809c959ceb7d43e3f5.diff

LOG: [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS

The plugin expects to have undefined references to symbols exported
by the loading process, which isn't supported by shared libraries
on windows.

Differential Revision: https://reviews.llvm.org/D74042

Added: 
    

Modified: 
    llvm/unittests/Passes/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Passes/CMakeLists.txt b/llvm/unittests/Passes/CMakeLists.txt
index 3e83b527958a..c04aa9f84458 100644
--- a/llvm/unittests/Passes/CMakeLists.txt
+++ b/llvm/unittests/Passes/CMakeLists.txt
@@ -7,24 +7,30 @@ if (LLVM_ENABLE_PLUGINS)
   add_definitions(-DLLVM_ENABLE_PLUGINS)
 endif()
 
-set(LLVM_LINK_COMPONENTS Support Passes Core)
-add_llvm_unittest(PluginsTests
-  PluginsTest.cpp
-  )
-export_executable_symbols(PluginsTests)
-target_link_libraries(PluginsTests PRIVATE LLVMTestingSupport)
+# The plugin expects to not link against the Support and Core libraries,
+# but expects them to exist in the process loading the plugin. This doesn't
+# work with DLLs on Windows (where a shared library can't have undefined
+# references), so just skip this testcase on Windows.
+if (NOT WIN32)
+  set(LLVM_LINK_COMPONENTS Support Passes Core)
+  add_llvm_unittest(PluginsTests
+    PluginsTest.cpp
+    )
+  export_executable_symbols(PluginsTests)
+  target_link_libraries(PluginsTests PRIVATE LLVMTestingSupport)
 
-set(LLVM_LINK_COMPONENTS)
-add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY
-  TestPlugin.cpp
-  )
+  set(LLVM_LINK_COMPONENTS)
+  add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY
+    TestPlugin.cpp
+    )
 
-# Put plugin next to the unit test executable.
-set_output_directory(TestPlugin
-  BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
-  LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
-  )
-set_target_properties(TestPlugin PROPERTIES FOLDER "Tests")
+  # Put plugin next to the unit test executable.
+  set_output_directory(TestPlugin
+    BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
+    LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
+    )
+  set_target_properties(TestPlugin PROPERTIES FOLDER "Tests")
 
-add_dependencies(TestPlugin intrinsics_gen)
-add_dependencies(PluginsTests TestPlugin)
+  add_dependencies(TestPlugin intrinsics_gen)
+  add_dependencies(PluginsTests TestPlugin)
+endif()