[PATCH] D72372: [CMake] Default to static linking for subprojects.

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:859
+#   The SUBPROJECT argument contains the LLVM project the plugin belongs
+#   to. If set, the plugin will link statically by default it if the 
+#   project was enabled.
----------------
nit: *the plugin will link it statically by default if...* 


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:868
 
-  option(LLVM_${name_upper}_LINK_INTO_TOOLS "Statically link ${name} into tools (if available)" OFF)
+  # Enable the plugin by default if it was explicitly enabled by the user.
+  # Note: If was set to "all", LLVM's CMakeLists.txt replaces it with a
----------------
nit: *link statically by default if it was...*


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72372/new/

https://reviews.llvm.org/D72372