[PATCH] D60581: [ValueLattice] Make mark* functions public, return if value changed.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:189
+
     assert(V && "Marking constant with NULL");
+
----------------
I believe this assert is useless after the isa<>. Can either be dropped or the previous order restored (not sure why it was changed?)


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:310
+      OtherCR = Other.getConstantRange();
+    else
       return nullptr;
----------------
Looks like this can now be reverted to the previous code (which avoids the awkward empty initializations...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60581/new/

https://reviews.llvm.org/D60581