[compiler-rt] 4050930 - [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137.

[Max Moroz via llvm-commits]

Author: Max Moroz
Date: 2020-02-10T10:28:06-08:00
New Revision: 405093045feb9435bb6f3871417338fd9832a591

URL: https://github.com/llvm/llvm-project/commit/405093045feb9435bb6f3871417338fd9832a591
DIFF: https://github.com/llvm/llvm-project/commit/405093045feb9435bb6f3871417338fd9832a591.diff

LOG: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137.

Summary:
The refactoring has caused a failure in
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/29265

The idea of failing the symbolization when the symbolizer bufer is too small
was incorrect. The symbolizer can be invoked for other frames that may fit into
the buffer and get symbolized.

Reviewers: vitalybuka, eugenis

Subscribers: dberris, #sanitizers, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D74343

Added: 
    

Modified: 
    compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
index e790789c8698..490c6fe89beb 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
@@ -529,8 +529,8 @@ bool SymbolizerProcess::ReadFromSymbolizer(char *buffer, uptr max_length) {
       break;
     if (read_len + 1 == max_length) {
       Report("WARNING: Symbolizer buffer too small\n");
-      buffer[0] = '\0';
-      return false;
+      read_len = 0;
+      break;
     }
   }
   buffer[read_len] = '\0';