[PATCH] D74343: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137.

[Max Moroz via Phabricator via llvm-commits]

Dor1s created this revision.
Dor1s added reviewers: vitalybuka, eugenis.
Herald added subscribers: llvm-commits, Sanitizers, dberris.
Herald added projects: Sanitizers, LLVM.
Dor1s accepted this revision.
Dor1s added a comment.
This revision is now accepted and ready to land.

Self-approval for a quick fix (reverting two lines in https://reviews.llvm.org/D74137).


The refactoring has caused a failure in
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/29265

The idea of failing the symbolization when the symbolizer bufer is too small
was incorrect. The symbolizer can be invoked for other frames that may fit into
the buffer and get symbolized.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74343

Files:
  compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp


Index: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
===================================================================
--- compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
+++ compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
@@ -529,8 +529,8 @@
       break;
     if (read_len + 1 == max_length) {
       Report("WARNING: Symbolizer buffer too small\n");
-      buffer[0] = '\0';
-      return false;
+      read_len = 0;
+      break;
     }
   }
   buffer[read_len] = '\0';


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74343.243618.patch
Type: text/x-patch
Size: 532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200210/66b6ab41/attachment.bin>