[PATCH] D74176: [CMake] Link against ZLIB::ZLIB

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 09:19:27 PST 2020


smeenai added inline comments.


================
Comment at: llvm/lib/Support/CMakeLists.txt:198
+  STRING(REGEX REPLACE "^${CMAKE_STATIC_LIBRARY_PREFIX}" "" zlib_library ${zlib_library})
+  STRING(REGEX REPLACE "${CMAKE_STATIC_LIBRARY_SUFFIX}$" "" zlib_library ${zlib_library})
+  set(llvm_system_libs ${llvm_system_libs} "${zlib_library}")
----------------
Shouldn't NAME_WE get rid of this already?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74176/new/

https://reviews.llvm.org/D74176





More information about the llvm-commits mailing list