[PATCH] D74302: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 09:01:23 PST 2020
nicolasvasilache added a comment.
> cmake seems broken
The joys of cross-toolchain edit and updates, should be fixed now (at least it runs locally).
================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Intrinsics.h:28
namespace intrinsics {
+namespace folded {
+/// Helper variadic abstraction to allow extending to any MLIR op without
----------------
ftynse wrote:
> This looks generally useful, any reason why it's under Linalg/ ?
The folder depends on FoldUtils which depends on StandardOps.
Splitting it out of EDSC is necessary, since Linalg is the only user for now I put it here to untangle for now.
Moved it to StandardOps for now but until FoldUtils drops the dependence (if possible?) it can't go at the top level.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74302/new/
https://reviews.llvm.org/D74302
More information about the llvm-commits
mailing list