[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 08:56:04 PST 2020
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me, just a nit about one of the comments.
Thanks for making this easier to review by splitting it up!
================
Comment at: llvm/include/llvm/Support/Process.h:205
+
+ /// When integrated-cc1 is disabled, terminate the current program.
+ /// When integrated-cc1 is enabled, terminates execution of the current
----------------
Could the comment be phrased in terms of CrashRecoveryContext instead of integrated-cc1, which is a Clang thing?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73742/new/
https://reviews.llvm.org/D73742
More information about the llvm-commits
mailing list