[PATCH] D74302: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies

Mon Feb 10 08:01:55 PST 2020

ftynse added a comment.

Layering-wise, this makes sense to me. EDSC is a utility library, similar to IR, and should not depend on an ever-growing set of dialects, rather the inverse.

I don't understand why the folder-related part is located under `Linalg/`, it does not look too specific to it ?

================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Intrinsics.h:28
 namespace intrinsics {
+namespace folded {
+/// Helper variadic abstraction to allow extending to any MLIR op without
----------------
This looks generally useful, any reason why it's under Linalg/ ?

================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:40

+using folded_std_constant_index = folded::ValueBuilder<ConstantIndexOp>;
+
----------------
Shouldn't this rather be in StandardOps/EDSC/Intrinsics?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74302/new/

https://reviews.llvm.org/D74302