[PATCH] D74226: [mlir][spirv] Introduce spv.function

[Lei Zhang via Phabricator via llvm-commits]

antiagainst updated this revision to Diff 243560.
antiagainst marked 17 inline comments as done.
antiagainst added a comment.
Herald added a reviewer: rriddle.

Address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74226/new/

https://reviews.llvm.org/D74226

Files:
  mlir/include/mlir/Dialect/GPU/GPUOps.td
  mlir/include/mlir/Dialect/SPIRV/SPIRVLowering.h
  mlir/include/mlir/Dialect/SPIRV/SPIRVOps.h
  mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td
  mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td
  mlir/include/mlir/IR/Function.h
  mlir/include/mlir/IR/FunctionSupport.h
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRVPass.cpp
  mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRVPass.cpp
  mlir/lib/Dialect/AffineOps/AffineOps.cpp
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
  mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
  mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp
  mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
  mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp
  mlir/lib/IR/Function.cpp
  mlir/test/Conversion/GPUToSPIRV/load-store.mlir
  mlir/test/Conversion/GPUToSPIRV/simple.mlir
  mlir/test/Conversion/LinalgToSPIRV/linalg-to-spirv.mlir
  mlir/test/Conversion/StandardToSPIRV/std-to-spirv.mlir
  mlir/test/Dialect/SPIRV/Serialization/arithmetic-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/array.mlir
  mlir/test/Dialect/SPIRV/Serialization/atomic-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/barrier.mlir
  mlir/test/Dialect/SPIRV/Serialization/bit-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/cast-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/composite-op.mlir
  mlir/test/Dialect/SPIRV/Serialization/constant.mlir
  mlir/test/Dialect/SPIRV/Serialization/entry-point.mlir
  mlir/test/Dialect/SPIRV/Serialization/execution-mode.mlir
  mlir/test/Dialect/SPIRV/Serialization/function-call.mlir
  mlir/test/Dialect/SPIRV/Serialization/global-variable.mlir
  mlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/group-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/logical-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/loop.mlir
  mlir/test/Dialect/SPIRV/Serialization/memory-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/module.mlir
  mlir/test/Dialect/SPIRV/Serialization/non-uniform-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/phi.mlir
  mlir/test/Dialect/SPIRV/Serialization/selection.mlir
  mlir/test/Dialect/SPIRV/Serialization/spec-constant.mlir
  mlir/test/Dialect/SPIRV/Serialization/struct.mlir
  mlir/test/Dialect/SPIRV/Serialization/terminator.mlir
  mlir/test/Dialect/SPIRV/Serialization/undef.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-load-store.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-simple.mlir
  mlir/test/Dialect/SPIRV/Transforms/inlining.mlir
  mlir/test/Dialect/SPIRV/Transforms/layout-decoration.mlir
  mlir/test/Dialect/SPIRV/control-flow-ops.mlir
  mlir/test/Dialect/SPIRV/ops.mlir
  mlir/test/Dialect/SPIRV/structure-ops.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74226.243560.patch
Type: text/x-patch
Size: 130741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200210/3bb8f628/attachment-0001.bin>