[PATCH] D74311: [CodeGen] Fix the computation of the alignment of split stores.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 07:11:59 PST 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG to me.



================
Comment at: llvm/test/CodeGen/PowerPC/split-store-alignment.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -mtriple=powerpc64le -codegenprepare -force-split-store < %s  | FileCheck --check-prefix=PPC64LE %s
+; RUN: opt -S -mtriple=powerpc64 -codegenprepare -force-split-store < %s  | FileCheck --check-prefix=PPC64 %s
+
----------------
Please unique checklines
```
; RUN: opt -S -mtriple=powerpc64le -codegenprepare -force-split-store < %s  | FileCheck --check-prefixes=ALL,PPC64LE %s
; RUN: opt -S -mtriple=powerpc64 -codegenprepare -force-split-store < %s  | FileCheck --check-prefixes=ALL,PPC64 %s

```


================
Comment at: llvm/test/CodeGen/PowerPC/split-store-alignment.ll:101-102
+; PPC64-NEXT:    [[TMP2:%.*]] = bitcast i64* [[P]] to i32*
+; PPC64-NEXT:    [[TMP3:%.*]] = getelementptr i32, i32* [[TMP2]], i32 1
+; PPC64-NEXT:    store i32 0, i32* [[TMP3]], align 4
+; PPC64-NEXT:    ret void
----------------
Okay, i guess there is no big-endian issue after all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74311/new/

https://reviews.llvm.org/D74311





More information about the llvm-commits mailing list