[PATCH] D74324: Tools emit the bug report URL on crash

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 06:44:17 PST 2020


gbreynoo created this revision.
gbreynoo added reviewers: jfb, scanon, kubamracek.
Herald added subscribers: llvm-commits, dexonsmith, hiraditya.
Herald added a project: LLVM.

When Clang crashes a useful message is output:

"PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script."

A similar message could be output for all tools.

I am unfamiliar with this area of LLVM. Any suggestions would be appreciated, particularly regarding the testing of this change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74324

Files:
  llvm/lib/Support/PrettyStackTrace.cpp


Index: llvm/lib/Support/PrettyStackTrace.cpp
===================================================================
--- llvm/lib/Support/PrettyStackTrace.cpp
+++ llvm/lib/Support/PrettyStackTrace.cpp
@@ -144,6 +144,8 @@
 /// This callback is run if a fatal signal is delivered to the process, it
 /// prints the pretty stack trace.
 static void CrashHandler(void *) {
+  errs() << "PLEASE submit a bug report to " BUG_REPORT_URL
+            " and include the crash backtrace\n";
 #ifndef __APPLE__
   // On non-apple systems, just emit the crash stack trace to stderr.
   PrintCurStackTrace(errs());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74324.243530.patch
Type: text/x-patch
Size: 598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200210/a2191e60/attachment.bin>


More information about the llvm-commits mailing list