[PATCH] D74285: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083)

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 05:07:11 PST 2020


samparker added inline comments.


================
Comment at: llvm/test/Transforms/EarlyCSE/commute.ll:344
 
+; Abs/nabs may exist with non-canonical operands. Value tracking can match those.
+; But we do not use value tracking, so we expect instcombine will canonicalize
----------------
Probably worth adding a run line to run instcombine before earlycse to test this expectation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74285/new/

https://reviews.llvm.org/D74285





More information about the llvm-commits mailing list