[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/Object/obj2yaml.test:734
 
+# RUN: obj2yaml %p/Inputs/trivial-object-test.elf-xtensa | FileCheck %s --check-prefix ELF-XTENSA
+
----------------
Rather than adding a pre-canned binary, use yaml2obj to generate a file.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-types-elf-xtensa.test:1
+## Test that llvm-readobj/llvm-readelf shows proper relocation type
+## names and values for xtensa target.
----------------
No need for "elf" to be in the file name, since it's in the ELF subdirectory.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-types-elf-xtensa.test:183
+         Type:   R_XTENSA_TLS_CALL
+
----------------
Delete extra blank line here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827