[PATCH] D74286: [ELF] Respect output section alignment for AT> (non-null lmaRegion)

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 02:11:09 PST 2020


grimar added inline comments.


================
Comment at: lld/test/ELF/linkerscript/lma-align.test:18
+## FIXME .data and .bss should be placed in different PT_LOAD segments
+## because their LMA regions are different.
+# CHECK-NEXT: LOAD  0x002010 0x0000000000011010 0x0000000000001020 0x000001 0x000031 RW  0x1000
----------------
grimar wrote:
> If you have a plan to fix it soon, it is fine, otherwise may be worth to create a bug and add a link here?
> 
> (nit: add a `:` after `FIXME`)
Ah, you've fixed it in D74297. I did not see it at the moment of writing this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74286/new/

https://reviews.llvm.org/D74286





More information about the llvm-commits mailing list