[PATCH] D73383: [Debuginfo] Allow retrieving source files relative to the compilation directory.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 01:53:07 PST 2020
jhenderson added a comment.
Aside from the inline comment, looks good to me.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:909
+ LineTable < = Gen->addLineTable();
+ LT.setCustomPrologue({
+ {33, LineTable::Long}, // unit length
----------------
saugustine wrote:
> jhenderson wrote:
> > Rather than needing to create an entire custom prologue, you can use `createBasicPrologue` to generate a default one, and then just tweak the contents to suit your needs (not forgetting to update the length fields in the process). See `ErrorForUnitLengthTooLarge` for an example usage.
> >
> > This will improve readability as it will more clearly show what is important to to this test.
> Doing this required modifying how basic prologues are created, which adds a few changes in random places. I had proposed D74249 separately, but the reviewer recommended I roll that into this.
As noted in D74249, you can avoid folding it in, by extending the `checkDefaultPrologue` checks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73383/new/
https://reviews.llvm.org/D73383
More information about the llvm-commits
mailing list