[PATCH] D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 01:45:56 PST 2020
jhenderson added a comment.
The change itself mostly looks fine to me, FWIW. An alternative to folding it into the other review would be to make a change in `checkDefaultPrologue` to check the new property of the FileNames, just like the name is already checked. The existing tests that use this function would then validate your changes.
I haven't been particularly happy with the constants in the `DwarfGenerator` code, although I have yet to come up with a viable alternative (not that I've thought about it all that much).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74249/new/
https://reviews.llvm.org/D74249
More information about the llvm-commits
mailing list