[PATCH] D74277: [MLIR][Affine] NFC: Move AffineValueMap and MutableAffineMap

Frank Laub via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 00:33:00 PST 2020


flaub marked an inline comment as done.
flaub added inline comments.


================
Comment at: mlir/lib/Dialect/AffineOps/AffineValueMap.cpp:75
+
+inline bool AffineValueMap::isMultipleOf(unsigned idx, int64_t factor) const {
+  return map.isMultipleOf(idx, factor);
----------------
rriddle wrote:
> We can drop the inline keywords now.
Should we drop them from headers too? (IIUC, they're just hints and they are redundant if the definition is already in a header).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74277/new/

https://reviews.llvm.org/D74277





More information about the llvm-commits mailing list