[PATCH] D74302: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies

[River Riddle via Phabricator via llvm-commits]

rriddle added a comment.

Any reason this couldn't have been split into multi revisions? e.g. one per dialect?



================
Comment at: mlir/include/mlir/Dialect/AffineOps/EDSC/Builders.h:58
+public:
+  // This entry point accommodates the fact that AffineForOp implicitly uses
+  // multiple `lbs` and `ubs` with one single `iv` and `step` to encode `max`
----------------
///


================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h:23
 namespace mlir {
+
+class AffineForOp;
----------------
Drop newline.


================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h:29
+namespace loop {
+
+class ParallelOp;
----------------
nit: Remove the newlines.


================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Intrinsics.h:28
 namespace intrinsics {
 
+namespace folded {
----------------
nit: Drop the newline.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/EDSC/Builders.h:19
+
+// Base class for MemRefBoundsCapture and VectorBoundsCapture.
+class BoundsCapture {
----------------
///


================
Comment at: mlir/include/mlir/EDSC/Builders.h:518
+  /// Emits a `store`.
+  // NOLINTNEXTLINE: unconventional-assign-operator
+  OperationHandle operator=(const TemplatedIndexedValue &rhs) {
----------------
We should be able to remove these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74302/new/

https://reviews.llvm.org/D74302