[PATCH] D73672: [MLIR][Standard] Implement constant folding for IndexCast

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 9 22:52:53 PST 2020


rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

Sorry for the delay. I was waiting for you to mark the comments as `Done` before returning to the review.



================
Comment at: mlir/lib/Dialect/StandardOps/Ops.cpp:1595
   }
+  auto value = cstOperands[0].dyn_cast_or_null<IntegerAttr>();
+  if (value) {
----------------
Can you merge this variable into the if condition?

(Can you resolve this?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73672/new/

https://reviews.llvm.org/D73672





More information about the llvm-commits mailing list