[PATCH] D74275: [compiler-rt] Compile __powitf2 under wasm

[Eli Friedman via Phabricator via llvm-commits]

efriedma requested changes to this revision.
efriedma added inline comments.
This revision now requires changes to proceed.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:147
   powitf2.c
+  powixf2.c
   subdf3.c
----------------
powixf2.c is, in fact, x86-specific.  At first glance it might not look like that, but the "x" in the name powixf2 refers exclusively to x86 long double.


================
Comment at: compiler-rt/lib/builtins/powitf2.c:15
 
-#if _ARCH_PPC
+#if defined(_ARCH_PPC) || defined(__wasm__)
 
----------------
Please change this so it matches the other 128 long double routines: it should include fp_lib.h, it should use the condition `#if defined(CRT_HAS_128BIT) && defined(CRT_LDBL_128BIT)`, and it should use fp_t instead of explicitly writing out "long double".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74275/new/

https://reviews.llvm.org/D74275