[PATCH] D74209: [AssumeBundle] Add documentation for the operand bundles of an llvm.assume

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/docs/LangRef.rst:2125-2128
+      call void @llvm.assume(i1 true) ["align"(i32* %val, i32 8)]
+
+allows the optimizer to assume that ``%val`` has an alignment of at least 8
+at this point.
----------------
jdoerfert wrote:
> lebedev.ri wrote:
> > It may be good to add a footnote that the arguments needn't be constants (or are they?)
> I would prefer not to require that. As long as we come from `llvm::Attribute` that is the case but we derive information from other places (e.g., the user) eventually.
Didn't read it properly. Good idea to say explicitly they might not be constant! Thx @lebedev.ri 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74209/new/

https://reviews.llvm.org/D74209