[PATCH] D70767: [Attributor] Add an Attributor CG-SCC pass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:525
 
+  // Infer attributes on declarations, call sites, arguments, etc.
+  MPM.add(createAttributorLegacyPass());
----------------
jdoerfert wrote:
> uenoku wrote:
> > Do you have any reason why you move Attributor here?
> The module pass should run early to improve the passes before the inliner loop, e.g., createCalledValuePropagationPass below.
Have you considered running it directly after IPSCCP? Then it would benefit from the existing constant propagation.

Also, running it unconditionally and then disabling it in the pass seems a bit odd (I think it was also discussed in another review which got abandoned IIRC). Is there a reason to not add it conditionally like we do with lots of other passes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70767/new/

https://reviews.llvm.org/D70767