[PATCH] D73590: [mlir] Add a document detailing the design of the SymbolTable.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/docs/SymbolsAndSymbolTables.md:5
+
+MLIR is a multi-level representation, with [Regions](LangRef.md#regions) the
+multi-level aspect is structural in the IR. A lot of infrastructure within the
----------------
This opening sentence is broken grammatically. 


================
Comment at: mlir/docs/SymbolsAndSymbolTables.md:96
+module {
+  // Error. We resolve references with respect to the closest parent symbol
+  // table, so this reference can't be resolved.
----------------
-> "closest parent op that has a symbol table". 

Otherwise, it's not clear here whether this means "closest parent op that has a symbol table" or "closest parent op that defines the symbol if any".  Unless I missed it, the resolution part isn't documented above. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73590/new/

https://reviews.llvm.org/D73590