[PATCH] D72533: [mlir] Add a signedness semantics bit to IntegerType

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/docs/Rationale.md:252
+additionally have signedness semantics. The purpose is to satisfy the needs of
+different dialects, which can model different level of abstractions. Certain
+abstraction, especially more near source language, might want to differentiate
----------------
different levels of abstractions 


================
Comment at: mlir/docs/Rationale.md:253
+different dialects, which can model different level of abstractions. Certain
+abstraction, especially more near source language, might want to differentiate
+signedness with integer types; while others, especially more near machine
----------------
more near -> closer to


================
Comment at: mlir/docs/Rationale.md:254
+abstraction, especially more near source language, might want to differentiate
+signedness with integer types; while others, especially more near machine
+instruction, might want signless integers. Instead of forcing each abstraction
----------------
likewise


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72533/new/

https://reviews.llvm.org/D72533