[PATCH] D72533: [mlir] Add a signedness semantics bit to IntegerType

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 8 15:05:00 PST 2020


antiagainst updated this revision to Diff 243410.
antiagainst marked 4 inline comments as done.
antiagainst added a comment.
Herald added subscribers: herhut, csigg, jholewinski.
Herald added a reviewer: mravishankar.

Address comments

- Went through `isa<IntergerType>` and `isInterger(...)` use sites to make sure they now use signless integer type where possible.
- Updated several APIs to include 'Signless' in the name to be explicit.
- Fixed typos


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72533/new/

https://reviews.llvm.org/D72533

Files:
  mlir/docs/LangRef.md
  mlir/docs/Rationale.md
  mlir/include/mlir/Dialect/FxpMathOps/FxpMathOps.td
  mlir/include/mlir/Dialect/GPU/GPUOps.td
  mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
  mlir/include/mlir/Dialect/QuantOps/QuantPredicates.td
  mlir/include/mlir/Dialect/QuantOps/UniformSupport.h
  mlir/include/mlir/Dialect/StandardOps/Ops.td
  mlir/include/mlir/Dialect/VectorOps/VectorOps.td
  mlir/include/mlir/IR/Attributes.h
  mlir/include/mlir/IR/Builders.h
  mlir/include/mlir/IR/Matchers.h
  mlir/include/mlir/IR/OpBase.td
  mlir/include/mlir/IR/OpDefinition.h
  mlir/include/mlir/IR/Operation.h
  mlir/include/mlir/IR/StandardTypes.h
  mlir/include/mlir/IR/Types.h
  mlir/lib/Analysis/Utils.cpp
  mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
  mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
  mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
  mlir/lib/Dialect/FxpMathOps/Transforms/UniformKernelUtils.h
  mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
  mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
  mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
  mlir/lib/Dialect/Linalg/Utils/Utils.cpp
  mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
  mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp
  mlir/lib/Dialect/StandardOps/Ops.cpp
  mlir/lib/EDSC/Builders.cpp
  mlir/lib/IR/AsmPrinter.cpp
  mlir/lib/IR/Attributes.cpp
  mlir/lib/IR/Builders.cpp
  mlir/lib/IR/MLIRContext.cpp
  mlir/lib/IR/Operation.cpp
  mlir/lib/IR/StandardTypes.cpp
  mlir/lib/IR/TypeDetail.h
  mlir/lib/Parser/Lexer.cpp
  mlir/lib/Parser/Parser.cpp
  mlir/lib/Parser/Token.cpp
  mlir/lib/Parser/Token.h
  mlir/lib/Parser/TokenKinds.def
  mlir/lib/Transforms/LoopFusion.cpp
  mlir/test/IR/invalid.mlir
  mlir/test/IR/parser.mlir
  mlir/test/lib/TestDialect/TestDialect.cpp
  mlir/test/lib/TestDialect/TestPatterns.cpp
  mlir/test/mlir-tblgen/op-attribute.td
  mlir/test/mlir-tblgen/predicate.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72533.243410.patch
Type: text/x-patch
Size: 70887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200208/cf0bc0a1/attachment.bin>


More information about the llvm-commits mailing list