[PATCH] D74019: [mlir] Add support for generating debug locations from intermediate levels of the IR.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/LocationSnapshot.cpp:42
+    if (it == opToLineCol.end())
+      return;
+    const std::pair<unsigned, unsigned> &lineCol = it->second;
----------------
mehdi_amini wrote:
> Is this expected / possible? Otherwise assert()? (if this is a valid case, can you add a comment?)
Yep, some region terminators are elided so they won't have a valid custom assembly form. Added a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74019/new/

https://reviews.llvm.org/D74019