[PATCH] D74276: [mlir][DeclarativeParser] Add support for attributes with buildable types.

Sat Feb 8 10:03:02 PST 2020

rriddle added a comment.

In D74276#1865578 <https://reviews.llvm.org/D74276#1865578>, @antiagainst wrote:

> It seems the parsers/printers modified in this patch does not use the attribute-type-ellison feature introduced in this patch? Can we touch parsers/printers really uses this feature?

Oops, got carried away late at night and forgot to split. Thanks for the catch!

================
Comment at: mlir/include/mlir/IR/OpBase.td:687

-// A generic attribute that must be constructed around a specific type
+// A generic attribute that must be constructed around a specific buildable type
 // `attrValType`. Backed by MLIR attribute kind `attrKind`.
----------------
antiagainst wrote:
> We removed the `BuildType` requirement but mentioned it in the comment?
An early revision reworked buildable types to be usable/settable outside of the BuildableType class.  Changing BuildableType -> Type just allows for more buildable types to be used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74276/new/

https://reviews.llvm.org/D74276