[PATCH] D74228: [PatternMatch] Match XOR variant of unsigned-add overflow check.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 8 04:35:21 PST 2020


nikic added a comment.

Not sure this is the right way to go about it. As we're only using the "overflow" result here, and don't need to collect two nominally independent instructions (potentially from different BBs), I don't think there's a strong reason to do this transform in CGP, as opposed to a setcc->uaddo DAG combine (if uaddo is legal).

Maybe @spatel can chime in, who implemented the handling in CGP.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74228/new/

https://reviews.llvm.org/D74228





More information about the llvm-commits mailing list