[PATCH] D73579: [mlir] Add elementAttr to TypedArrayAttrBase.

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 8 04:06:20 PST 2020


antiagainst requested changes to this revision.
antiagainst added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/test/mlir-tblgen/op-attribute.td:250
+
+// RECORD: Attr elementAttr = SomeAttr;
----------------
Can we have `RECORD-LABEL` to match `SomeTypedArrayAttr` before this? Otherwise it's too broad a range to match against.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73579/new/

https://reviews.llvm.org/D73579





More information about the llvm-commits mailing list