[PATCH] D74019: [mlir] Add support for generating debug locations from intermediate levels of the IR.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: mlir/lib/Transforms/LocationSnapshot.cpp:30
+  if (!tag.empty())
+    tagIdentifier = builder.getIdentifier(tag);
+
----------------
Can this all move after the printing?


================
Comment at: mlir/lib/Transforms/LocationSnapshot.cpp:42
+    if (it == opToLineCol.end())
+      return;
+    const std::pair<unsigned, unsigned> &lineCol = it->second;
----------------
Is this expected / possible? Otherwise assert()? (if this is a valid case, can you add a comment?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74019/new/

https://reviews.llvm.org/D74019