[PATCH] D74185: Revert the revert of vectorization commits

[Sanjoy Das (Work Account) via Phabricator via llvm-commits]

sanjoy.google added a comment.

In D74185#1865186 <https://reviews.llvm.org/D74185#1865186>, @ABataev wrote:

> In D74185#1865175 <https://reviews.llvm.org/D74185#1865175>, @sanjoy.google wrote:
>
> > In D74185#1865088 <https://reviews.llvm.org/D74185#1865088>, @ABataev wrote:
> >
> > > Thanks, will check this.
> >
> >
> > Should we revert the commit while you investigate?
>
>
> The problem here that this patch does not introduce new vectorization, instead it just triggers the existing vetorization for more cases. If there is a bug in the vectorizer, this patch just allows to reveal it, not introduces it.


Even if we believe that this commit only reveals a bug (and is itself buggy) I think the correct action is to revert.  I have done this in the past with my changes.

Reverting is not a indictment on the quality of the change being reverted; it just keeps the trunk green and helps us all sleep better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74185/new/

https://reviews.llvm.org/D74185