[PATCH] D74257: IR Linking: Support merging Warning+Max module metadata flags

[David Blaikie via Phabricator via llvm-commits]

dblaikie created this revision.
dblaikie added a reviewer: tejohnson.
Herald added subscribers: llvm-commits, hiraditya, aprantl.
Herald added a project: LLVM.
dblaikie added reviewers: aprantl, JDevlieghere, probinson.
dblaikie edited the summary of this revision.

Debug Info Version was changed to use "Max" instead of "Warning" per the
original design intent - but this maxes old/new IR unlinkable, since
mismatched merge styles are a linking failure.

It seems possible/maybe reasonable to actually support the combination
of these two flags: Warn, but then use the maximum value rather than the
first value/earlier module's value.

To fix: https://bugs.llvm.org/show_bug.cgi?id=44784


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74257

Files:
  llvm/docs/LangRef.rst
  llvm/lib/Linker/IRMover.cpp
  llvm/test/Linker/Inputs/module-max-warn.ll
  llvm/test/Linker/module-max-warn.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74257.243290.patch
Type: text/x-patch
Size: 5521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200207/4a6dc208/attachment.bin>