[PATCH] D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D74249#1864995 <https://reviews.llvm.org/D74249#1864995>, @saugustine wrote:

> In D74249#1864942 <https://reviews.llvm.org/D74249#1864942>, @dblaikie wrote:
>
> > It'd be helpful to add something that exercises the new functionality along with the functionality (not necessarily a test /for/ the functionality (since this is test functionality, and then you get in the infinite rabbit hole of testing testing) - but potentially in some libDEbugInfo unit test that uses this functionality and wouldn't be possible without it?)
>
>
> D73383 <https://reviews.llvm.org/D73383> will use this functionality, but because it is logically separate, I thought it best to submit it separately.


Yeah, it's a tricky tradeoff - trying to isolate changes, but equally trying not to commit untested/unverified functionality.

If it's possible to/you could refactor the constants (in DWARFDebugLineTest.cpp and dwarfgen::LineTable::createBasicPrologue ) so they're symbolic/don't need to be updated when writeV5IncludeAndFileTable is made - taht'd be a good isolated "NFC" commit. But no worries if that isn't possible.

Otherwise/please roll this into the other review, so the functionality is exercised when it's committed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74249/new/

https://reviews.llvm.org/D74249