[PATCH] D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 14:16:22 PST 2020


daltenty added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-str.ll:70
+; CHECKOBJ:     00000010 .rodata.str2.2:
+; CHECKOBJ-NEXT:       10: 01 08 01 10                          <unknown>
+; CHECKOBJ-NEXT:       14: 00 d5 00 00                          <unknown>{{[[:space:]] *}}
----------------
nit: Should we really be matching the memonics column of the objdump output since it's not meaningful here? We really only care about the raw bytes. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74164/new/

https://reviews.llvm.org/D74164





More information about the llvm-commits mailing list