[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Sorry, one more pile-on comment: We were a bit lucky that we had a random test act as system test for our crash processing. If that hadn't happened, we wouldn't have seen this breakage and only eventually would have noticed that we no longer get crashes from the field. (I'm surprised we don't have dedicated crash tests! I'm sure we do somewhere and I'll follow up on why those didn't run.) But missing crash reports would've been a pain to track down. I could see assembly in other projects having a similar edge-case role, so this might cause similar problems there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73542/new/

https://reviews.llvm.org/D73542