[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.

Fri Feb 7 12:35:51 PST 2020

thakis added a comment.

I debugged this a bit. This time around, it's the assembly issue we originally expected :/

https://bugs.chromium.org/p/chromium/issues/detail?id=1049649#c7
https://bugs.chromium.org/p/chromium/issues/detail?id=1049649#c8
https://bugs.chromium.org/p/chromium/issues/detail?id=1049649#c9

I'll land that crashpad change, but this seems like a risky change to me. Maybe we could teach clang's integrated assembler to warn on `.globl`s without an explicit `.type` when writing arm output before relanding or something? We (chromium) will be happy after the crashpad change I assume, but other projects out there that don't track upstream as closely might run into problems.

At the very least, this should have a release notes entry :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73542/new/

https://reviews.llvm.org/D73542