[PATCH] D73862: [RISCV] Fix incorrect FP base CFI offset for variable argument functions

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.
Herald added a subscriber: evandro.

LGTM (just tweak the comment).



================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:184
 
-    // Emit ".cfi_def_cfa $fp, 0"
+    // Emit ".cfi_def_cfa $fp, RVFI->getVarArgsSaveSize()"
     unsigned CFIIndex = MF.addFrameInst(MCCFIInstruction::createDefCfa(
----------------
This comment is lacking the `-` of the code below. I understand that the value emitted is positive, but the way the comment is written it's inconsistent with the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73862/new/

https://reviews.llvm.org/D73862