[PATCH] D74169: [LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info.

[Alexey Lapshin via Phabricator via llvm-commits]

avl marked 13 inline comments as done.
avl added inline comments.


================
Comment at: lld/ELF/CMakeLists.txt:38
   MarkLive.cpp
+  LLDDwarfLinker.cpp
   OutputSections.cpp
----------------
grimar wrote:
> I'd not add "LLD" prefix. All if sources here belong to "LLD" actually.
The idea is that the file name matches the class name. The class name has LLD to be different from DWARFLinker from DWARFLinker library. If it looks redundant, then I would delete this prefix.  


================
Comment at: lld/ELF/CMakeLists.txt:57
+  DWARFLinker
+  AsmPrinter
   Demangle
----------------
MaskRay wrote:
> Is AsmPrinter used?
It is used because LLDDwarfLinker.cpp includes DWARFLinker.h, which  includes "llvm/CodeGen/Die.h", which needs  "llvm::DIEAbbrev::Profile(llvm::FoldingSetNodeID&)" which is in AsmPrinter.

probably it could be refactored out later.  


================
Comment at: lld/ELF/LLDDwarfLinker.cpp:12
+// such abandoned debug info LLDDwarfLinker analyzes relocations and removes
+// debug info related to deleted sections.
+//
----------------
grimar wrote:
> Is it a final version of the comment? I'd expect to habe more information here probably about what we exactly do.
Ok, I would put more detailed comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74169/new/

https://reviews.llvm.org/D74169