[PATCH] D72358: [llvm-objcopy][test] Fix tests when path contains "bar"

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 11:58:21 PST 2020


dblaikie added a comment.

In D72358#1850950 <https://reviews.llvm.org/D72358#1850950>, @MaskRay wrote:

> The argument in D72357 <https://reviews.llvm.org/D72357> does not need to block this patch. I'll push this, as a straightforward improvement over the existing tests, so that @jlebar and @bbaren can be happy.


I feel like this kind of ignored specific feedback I had on the other review that applied equally here. Had I known about this review/commit, I would've objected to it on the same grounds.

Please use redirection in this and future tests to address issues like this to help make tests more resilient to interesting paths on developer/test machines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72358/new/

https://reviews.llvm.org/D72358





More information about the llvm-commits mailing list