[PATCH] D74119: [NFC][mlir] Adding some helpful EDSC intrinsics
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 7 11:21:44 PST 2020
nicolasvasilache requested changes to this revision.
nicolasvasilache added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/include/mlir/EDSC/Intrinsics.h:202
using call = OperationBuilder<mlir::CallOp>;
+using constant_data = ValueBuilder<ConstantOp>;
using constant_float = ValueBuilder<ConstantFloatOp>;
----------------
ftynse wrote:
> Please make sure the name corresponds to the instruction name, e.g. ConstantOp should be just `constant`.
this breaks the build, please fix the other use case:
```
llvm-project/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp: In member function ‘virtual mlir::PatternMatchResult {anonymous}::SliceOpConversion::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::Value>, mlir::ConversionPatternRewriter&) const’:
llvm-project/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:268:9: error: reference to ‘constant’ is ambiguous
268 | constant(int64Ty, rewriter.getIntegerAttr(rewriter.getIndexType(), 0));
| ^~~~~~~~
In file included from llvm-project/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:20:
llvm-project/mlir/include/mlir/EDSC/Intrinsics.h:203:7: note: candidates are: ‘using constant = struct mlir::edsc::intrinsics::ValueBuilder<mlir::ConstantOp>’
203 | using constant = ValueBuilder<ConstantOp>;
| ^~~~~~~~
llvm-project/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:54:7: note: ‘using constant = struct mlir::edsc::intrinsics::ValueBuilder<mlir::LLVM::ConstantOp>’
54 | using constant = ValueBuilder<mlir::LLVM::ConstantOp>;
| ^~~~~~~~
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74119/new/
https://reviews.llvm.org/D74119
More information about the llvm-commits
mailing list