[PATCH] D74242: [CodeGenPrepare] Handle ExtractValueInst in dupRetToEnableTailCallOpts

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2111-2113
+      for (auto i = EVI->idx_begin(), e = EVI->idx_end(); i != e; i++)
+        if (*i != 0)
+          return false;
----------------
getIndices() == { 0 }?


================
Comment at: llvm/test/CodeGen/X86/tailcall-extract.ll:2
+; RUN: llc -mtriple=x86_64-linux < %s | FileCheck %s
+
+
----------------
Should also have a run line checking the IR after just codegenprepare


================
Comment at: llvm/test/CodeGen/X86/tailcall-extract.ll:28
+  %call1.i.sink = phi { i8*, i64 } [ %call1.i, %if.then.i ], [ %call2.i, %if.end.i ]
+  %0 = extractvalue { i8*, i64 } %call1.i.sink, 0
+  ret i8* %0
----------------
Use a named value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74242/new/

https://reviews.llvm.org/D74242