[PATCH] D74171: [mlir] [LLVMIR] add all vector reduction intrinsics to LLVM IR dialect

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 10:26:39 PST 2020


rriddle requested changes to this revision.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:789
+    Arguments<(ins LLVM_Type)>, Results<(outs LLVM_Type:$res)> {
+  let llvmBuilder = [{
+    llvm::Module *module = builder.GetInsertBlock()->getModule();
----------------
Can you define a template for these? The builder is effectively the same for all of these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74171/new/

https://reviews.llvm.org/D74171





More information about the llvm-commits mailing list