[PATCH] D74178: [scudo][standalone] 32-bit improvement

Fri Feb 7 10:26:35 PST 2020

cryptoad marked 3 inline comments as done.
cryptoad added inline comments.

================
Comment at: compiler-rt/lib/scudo/standalone/primary32.h:261
     if (LIKELY(Region)) {
-      if (ClassId) {
-        const uptr RegionIndex = computeRegionId(Region);
----------------
pcc wrote:
> Why remove this if? Looks like we never end up going from non-zero to zero in `PossibleRegions` so the only effect is that we end up setting `MinRegionIndex`/`MaxRegionIndex` to cover transfer batches which are ignored by `iterateOverBlocks`/`releaseToOSMaybe` anyway?
This was changed to allow releasing of the transfer batches  (currently only via the "forced" release).
0 is now unused, which is different from the transfer batch class id.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74178/new/

https://reviews.llvm.org/D74178