[PATCH] D74223: [GlobalISel] Add buildMerge with SrcOp initializer list

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 09:40:25 PST 2020


Petar.Avramovic marked an inline comment as done.
Petar.Avramovic added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:792
+  MachineInstrBuilder buildMerge(const DstOp &Res,
+                                 std::initializer_list<SrcOp> Ops);
 
----------------
foad wrote:
> Why std::initializer_list instead of ArrayRef? Is it something to do with ambiguous overloads? Do we still need the ArrayRef<Register> overload at all?
Old one with ArrayRef<Register> is required when argument is something like an actual SmallVector<Register>. It could also be used with brace enclosed initializer list filled with Registers.
New one is for brace enclosed initializer list with arguments that can be converted to SrcOp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74223/new/

https://reviews.llvm.org/D74223





More information about the llvm-commits mailing list