[PATCH] D73990: [Sanitizers] Get link map on FreeBSD via documented API

[Ed Maste via Phabricator via llvm-commits]

emaste added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:29-30
 namespace __sanitizer {
+// FreeBSD's dlopen() returns a pointer to an Obj_Entry structure that
+// incorporates the map structure.
+void *__sanitizer_get_link_map_by_dlopen_handle(void *handle);
----------------
dim wrote:
> emaste wrote:
> > I don't think the comment is applicable now
> Well, it is still informative in the sense that it tells you the `handle` parameter (which is apparently the return value from dlopen) does not directly point to the desired link map information
> 
> Would you rather delete the comment, or replace it with something else? If the latter, what? :)
I would delete it - the macro name is pretty explicit about obtaining the link map from the dlopen handle :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73990/new/

https://reviews.llvm.org/D73990