[PATCH] D74162: [Inliner] Inlining should honor nobuiltin attributes

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

Apart from my other comment LGTM



================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:393
     return PartialInlinerImpl(&GetAssumptionCache, LookupAssumptionCache,
-                              &GetTTI, NoneType::None, PSI)
+                              &GetTTI, NoneType::None, &GetTLI, PSI)
         .run(M);
----------------
I'm having a hard time convincing myself that the lifetime requirements are correct here.
Passing a local variable `GetTLI` by address in `return` statement looks fishy.

It's similar to `GetTTI` so is seems correct, it's just hard to tell by looking at the code.

Same above and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74162/new/

https://reviews.llvm.org/D74162